-
Notifications
You must be signed in to change notification settings - Fork 3.7k
branch-4.0: [fix](restore) Preserve cross-database references when restoring views #59580 #59662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#59580) When restoring a view to a different database, the current implementation incorrectly replaces **all** database names in the view definition with the target database name. This breaks cross-database references. **Example:** - Original: `view_db` has a view referencing tables from both `base_db` and `view_db` ```sql SELECT * FROM `internal`.`base_db`.`table1` JOIN `internal`.`view_db`.`table2` ``` - After restore to `restore_db` (BEFORE this PR): ```sql SELECT * FROM `internal`.`restore_db`.`table1` -- ❌ Wrong! Should be base_db JOIN `internal`.`restore_db`.`table2` -- ✅ Correct ``` - After restore to `restore_db` (AFTER this PR): ```sql SELECT * FROM `internal`.`base_db`.`table1` -- ✅ Correct! Preserved JOIN `internal`.`restore_db`.`table2` -- ✅ Correct ``` **Root Cause:** The regex pattern `(?<=\`internal\`\\.\`)([^\`]+)(?=\`\\.\`)` matches **any** database name, not just the source database name.
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
|
run buildall |
Contributor
|
run feut |
Contributor
FE UT Coverage ReportIncrement line coverage |
Contributor
|
run cloud_p0 |
1 similar comment
Contributor
|
run cloud_p0 |
yiguolei
approved these changes
Jan 12, 2026
Contributor
|
skip buildall |
Contributor
Author
|
PR approved by at least one committer and no changes requested. |
Contributor
Author
|
PR approved by anyone and no changes requested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picked from #59580